From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Tiejun Chen <tiejun.chen@intel.com>,
xen-devel@lists.xen.org, ian.jackson@eu.citrix.com,
stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH] tools/libxl: cleanup one libxl__calloc() usage
Date: Wed, 11 Mar 2015 12:30:52 +0000 [thread overview]
Message-ID: <1426077052.21353.231.camel@citrix.com> (raw)
In-Reply-To: <20150310092146.GA4330@zion.uk.xensource.com>
On Tue, 2015-03-10 at 09:21 +0000, Wei Liu wrote:
> On Tue, Mar 10, 2015 at 02:28:16PM +0800, Tiejun Chen wrote:
> > Its pointless because internally, libxl__calloc() would always
> > terminate program execution if failed,
> >
> > libxl__calloc()
> > |
> > + void *ptr = calloc(nmemb, size);
> > + if (!ptr) libxl__alloc_failed(CTX, __func__, nmemb, size);
> > |
> > + _exit(-1);
> >
> > Signed-off-by: Tiejun Chen <tiejun.chen@intel.com>
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
Likewise + applied, thanks.
prev parent reply other threads:[~2015-03-11 12:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 6:28 [PATCH] tools/libxl: cleanup one libxl__calloc() usage Tiejun Chen
2015-03-10 9:21 ` Wei Liu
2015-03-11 12:30 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426077052.21353.231.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tiejun.chen@intel.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.