From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 8/9] xl: make error reporting of cpupool subcommands consistent Date: Wed, 11 Mar 2015 14:52:31 +0000 Message-ID: <1426085551.21353.254.camel@citrix.com> References: <20150306170758.7269.53821.stgit@Solace.station> <20150306172159.7269.37267.stgit@Solace.station> <20150309110122.GK18491@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150309110122.GK18491@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Juergen Gross , Dario Faggioli , Stefano Stabellini , Ian Jackson , Xen-devel List-Id: xen-devel@lists.xenproject.org On Mon, 2015-03-09 at 11:01 +0000, Wei Liu wrote: > On Fri, Mar 06, 2015 at 06:21:59PM +0100, Dario Faggioli wrote: > > with the rest of the file, where we return 1 on 0, rather > > than using libxl error codes. > > > > While being consistent is good I'm not very sure if we should go for 0/1 > rather than libxl error codes. I vaguely remember at some point we > discussed we should make xl exit code better but I don't remember the > exact details. > > Ian and Ian, what do you think? TBH I'm not sure what exit() called with a negative number even results in. I think having more consistent exist codes from xl would be nice, but I don't think the libxl error codes are the ones to use, since they don't really map semantically onto what I would expect a CLI tool to fail with (I'm not sure what I would expect though, something a bit higher level on a command specific basis probably).