From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 8/9] xl: make error reporting of cpupool
 subcommands consistent
Date: Wed, 11 Mar 2015 15:14:21 +0000
Message-ID: <1426086861.21353.269.camel@citrix.com>
References: <20150306170758.7269.53821.stgit@Solace.station>
	<20150306172159.7269.37267.stgit@Solace.station>
	<20150309110122.GK18491@zion.uk.xensource.com>
	<1426085551.21353.254.camel@citrix.com>
	<20150311150444.GA1643@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150311150444.GA1643@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: Juergen Gross <JGross@suse.com>, Dario Faggioli <dario.faggioli@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-03-11 at 15:04 +0000, Wei Liu wrote:
> On Wed, Mar 11, 2015 at 02:52:31PM +0000, Ian Campbell wrote:
> > On Mon, 2015-03-09 at 11:01 +0000, Wei Liu wrote:
> > > On Fri, Mar 06, 2015 at 06:21:59PM +0100, Dario Faggioli wrote:
> > > > with the rest of the file, where we return 1 on 0, rather
> > > > than using libxl error codes.
> > > > 
> > > 
> > > While being consistent is good I'm not very sure if we should go for 0/1
> > > rather than libxl error codes. I vaguely remember at some point we
> > > discussed we should make xl exit code better but I don't remember the
> > > exact details.
> > > 
> > > Ian and Ian, what do you think?
> > 
> > TBH I'm not sure what exit() called with a negative number even results
> > in.
> > 
> > I think having more consistent exist codes from xl would be nice, but I
> > don't think the libxl error codes are the ones to use, since they don't
> > really map semantically onto what I would expect a CLI tool to fail with
> > (I'm not sure what I would expect though, something a bit higher level
> > on a command specific basis probably).
> > 
> 
> I agree that libxl error codes are not the ones to use.
> 
> Since we haven't explicitly defined any return value in xl manpage, I
> think we should use EXIT_SUCCESS and EXIT_FAILURE per exit(3). They are
> more appropriate then 0 and 1.

I guess so, yes.

Ian.