From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v7 18/21] libxlu: record location when parsing values Date: Wed, 11 Mar 2015 15:36:04 +0000 Message-ID: <1426088164.21353.283.camel@citrix.com> References: <1425905497-30835-1-git-send-email-wei.liu2@citrix.com> <1425905497-30835-19-git-send-email-wei.liu2@citrix.com> <1426086769.21353.268.camel@citrix.com> <20150311151629.GB1643@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150311151629.GB1643@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Wed, 2015-03-11 at 15:16 +0000, Wei Liu wrote: > On Wed, Mar 11, 2015 at 03:12:49PM +0000, Ian Campbell wrote: > > On Mon, 2015-03-09 at 12:51 +0000, Wei Liu wrote: > > > Originally only setting has line number recorded. Since we're moving to > > > more sophisticated API, record the location for individual value. It is > > > useful for error reporting. > > > > > > Signed-off-by: Wei Liu > > > Cc: Ian Campbell > > > Cc: Ian Jackson > > > > I'm leaving this one to Ian. > > > > Do we need to rerun something (bison/flex?) on commit? > > > > These commits already contains bison / flex outputs. I used Wheezy's > flex and bison. > > I can exclude them from the patch if necessary. Since you've got the right versions and the diff is small I think we can live with them there. I think my precommit scripts will force a regen, which would highlight if there was any skew. Ian.