From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 8/9] xl: make error reporting of cpupool subcommands consistent Date: Wed, 11 Mar 2015 16:22:00 +0000 Message-ID: <1426090918.21405.12.camel@citrix.com> References: <20150306170758.7269.53821.stgit@Solace.station> <20150306172159.7269.37267.stgit@Solace.station> <20150309110122.GK18491@zion.uk.xensource.com> <1426085551.21353.254.camel@citrix.com> <20150311150444.GA1643@zion.uk.xensource.com> <1426086800.21405.8.camel@citrix.com> <20150311152302.GC1643@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5911173641108010896==" Return-path: In-Reply-To: <20150311152302.GC1643@zion.uk.xensource.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: "JGross@suse.com" , Ian Jackson , Stefano Stabellini , Ian Campbell , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org --===============5911173641108010896== Content-Language: en-US Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-K+Rt2pyw4OmFv16rCJdp" --=-K+Rt2pyw4OmFv16rCJdp Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2015-03-11 at 15:23 +0000, Wei Liu wrote: > On Wed, Mar 11, 2015 at 03:13:33PM +0000, Dario Faggioli wrote: > > On Wed, 2015-03-11 at 15:04 +0000, Wei Liu wrote: > > > Since we haven't explicitly defined any return value in xl manpage, I > > > think we should use EXIT_SUCCESS and EXIT_FAILURE per exit(3).=20 > > > > > I like the idea. > >=20 > > > They are > > > more appropriate then 0 and 1. > > >=20 > > Indeed. However, as far as this patch is concerned, what should I do? > >=20 > > b) keep it, we'll convert the 0/1 to EXIT_SUCCESS/FAILURE in later > > patch(es) > > ? > >=20 > > My opinion, I don't like c), so I'd go for either a) or b), with a > > slight preference for b). > >=20 >=20 > I think b) is good. >=20 Right. It was the only comment you made on this patch... does that means I can stick your Acked/Reviewed -by tag to it when sending v2? Dario --=-K+Rt2pyw4OmFv16rCJdp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlUAa6YACgkQk4XaBE3IOsRBEwCfYyQsjudQePAOmDmAdQoIejBH Zp4AoJVX51uj7ZhFSoVV5RqPy5QbETJe =ER3m -----END PGP SIGNATURE----- --=-K+Rt2pyw4OmFv16rCJdp-- --===============5911173641108010896== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============5911173641108010896==--