From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 1/2] tools: OVMF parallel build Date: Wed, 11 Mar 2015 16:41:32 +0000 Message-ID: <1426092092.21353.322.camel@citrix.com> References: <1425293541-26183-1-git-send-email-wei.liu2@citrix.com> <1425293541-26183-2-git-send-email-wei.liu2@citrix.com> <1425305938.21151.48.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1425305938.21151.48.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: anthony.perard@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Mon, 2015-03-02 at 14:18 +0000, Ian Campbell wrote: > On Mon, 2015-03-02 at 10:52 +0000, Wei Liu wrote: > > Though it doesn't work with make's "-j" option, the build system of OVMF > > has an option to specify parallel threads used to run the build. > > > > Using 4 threads to build OVMF looks like a sensible default. > > It's a bit arbitrary, but it'll do, I suppose. > > It's worth noting that this won't interact with gnu makes token handling > which is used to make sure there are only N processes across the > recursive build. So this will consume 1 token but launch 4 threads. So > if -j4 is used you'll actually get 7 things happening. > > I think we can live with that. > > So I'm happy with the patch, but I'd like to give others a chance to > disagree before applying. They had their chance... > > > Signed-off-by: Wei Liu > > Cc: Anthony Perard > > Acked-by: Ian Campbell ... applied. Did the distclean issue which the second patch was addressing get fixed another way or is there a patch outstanding somewhere?