From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([5.9.151.49] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YVmDu-0000kc-Vw for ath10k@lists.infradead.org; Wed, 11 Mar 2015 19:23:19 +0000 Message-ID: <1426101761.1904.10.camel@sipsolutions.net> Subject: Re: [PATCH RFC v2] ath10k: move code from parameter list into a function From: Johannes Berg Date: Wed, 11 Mar 2015 20:22:41 +0100 In-Reply-To: <20150311191526.GA24455@opentech.at> References: <1426100519-20636-1-git-send-email-hofrat@osadl.org> <1426101010.1904.9.camel@sipsolutions.net> <20150311191526.GA24455@opentech.at> Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Nicholas Mc Guire Cc: Jeff Haran , Valdis.Kletnieks@vt.edu, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, Kalle Valo , Nicholas Mc Guire , Pat Erley , Bj??rn Mork On Wed, 2015-03-11 at 20:15 +0100, Nicholas Mc Guire wrote: > I'm not into this long enough to say what is better and if the consensus > is that this patch is no more readable than the original code > and no more maintainable either, then it is not worth the effort. Personally, I like the change, it might even make that function more reusable etc., and it gets rid of the ({ ... }) expression syntax which I always find a bit odd :) johannes _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([5.9.151.49]:49161 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751057AbbCKTW6 (ORCPT ); Wed, 11 Mar 2015 15:22:58 -0400 Message-ID: <1426101761.1904.10.camel@sipsolutions.net> (sfid-20150311_202321_194290_25235FB1) Subject: Re: [PATCH RFC v2] ath10k: move code from parameter list into a function From: Johannes Berg To: Nicholas Mc Guire Cc: Nicholas Mc Guire , Kalle Valo , Valdis.Kletnieks@vt.edu, Bj??rn Mork , Jeff Haran , Pat Erley , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 11 Mar 2015 20:22:41 +0100 In-Reply-To: <20150311191526.GA24455@opentech.at> References: <1426100519-20636-1-git-send-email-hofrat@osadl.org> <1426101010.1904.9.camel@sipsolutions.net> <20150311191526.GA24455@opentech.at> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, 2015-03-11 at 20:15 +0100, Nicholas Mc Guire wrote: > I'm not into this long enough to say what is better and if the consensus > is that this patch is no more readable than the original code > and no more maintainable either, then it is not worth the effort. Personally, I like the change, it might even make that function more reusable etc., and it gets rid of the ({ ... }) expression syntax which I always find a bit odd :) johannes