From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v2] RFC: Automatically check xen's public
 headers for C++ pitfalls.
Date: Thu, 12 Mar 2015 10:14:49 +0000
Message-ID: <1426155289.21353.359.camel@citrix.com>
References: <1424956264-15271-1-git-send-email-tim@xen.org>
	<1424967096-6105-1-git-send-email-tim@xen.org>
	<20150226162842.GG43832@deinos.phlegethon.org>
	<20150305112557.GC86322@deinos.phlegethon.org>
	<1425555354.25940.220.camel@citrix.com>
	<54F84F0C0200007800066918@mail.emea.novell.com>
	<1425556555.25940.221.camel@citrix.com>
	<20150305121617.GD86322@deinos.phlegethon.org>
	<20150312100301.GA22158@deinos.phlegethon.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150312100301.GA22158@deinos.phlegethon.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tim Deegan <tim@xen.org>
Cc: Keir Fraser <keir@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>, Jan Beulich <JBeulich@suse.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Thu, 2015-03-12 at 11:03 +0100, Tim Deegan wrote:
> At 13:16 +0100 on 05 Mar (1425557777), Tim Deegan wrote:
> > At 11:55 +0000 on 05 Mar (1425552955), Ian Campbell wrote:
> > > On Thu, 2015-03-05 at 11:41 +0000, Jan Beulich wrote:
> > > > >>> On 05.03.15 at 12:35, <ian.campbell@citrix.com> wrote:
> > > > > On Thu, 2015-03-05 at 12:25 +0100, Tim Deegan wrote:
> > > > >> So I've seen four responses in favour of just renaming the field
> > > > >> (Andrew Cooper, Razvan Cojocaru, Don Slutz and David Vrabel) and one
> > > > >> in favour of #ifdeffing it so it's only renamed in C++ (Jan Beulich).
> > > > >> I really don't like adding more #ifdefs to an already hard-to-read
> > > > >> file; I'd rather just rename the field, or else leaving it alone and
> > > > >> letting C++ users carry the fixup in their own code.
> > > > >> 
> > > > >> CC'ing the other "THE REST" maintainers for their opinions.
> > > > > 
> > > > > Rather than ifdefs for C++, don't we need them based on
> > > > > __XEN_INTERFACE_VERSION__?
> > > > 
> > > > That's not applicable to the stuff under public/io/.
> > > 
> > > In which case I'd certainly prefer just changing the name and getting it
> > > over with.
> > > 
> > > mini-os would need checking, since that's (AFAIK) the only intree user
> > > of these headers.
> > 
> > mini-os doesn't in fact use this field; it's a blktap2-ism.
> > Here's a (non-RFC) patch to rename it and update blktap2:
> 
> Ian, Jan, can I get an Ack or Nack on this so I can clear it off my
> plate? :)

Acked-by: Ian Campbell <ian.campbell@citrix.com>