From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH V13 1/7] xen/arm: p2m changes for mem_access
	support
Date: Thu, 12 Mar 2015 13:55:21 +0000
Message-ID: <1426168521.32572.4.camel@citrix.com>
References: <1425677073-13729-1-git-send-email-tklengyel@sec.in.tum.de>
	<1425677073-13729-2-git-send-email-tklengyel@sec.in.tum.de>
	<55018D24.9030603@linaro.org>
	<CABfawhmwZ_pnADDS1b82syRu9xPLSgp6kSWt1XJ=ryvacQOzUQ@mail.gmail.com>
	<550193C8.3060209@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <550193C8.3060209@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>
Cc: wei.liu2@citrix.com, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Tim Deegan <tim@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, Jan Beulich <jbeulich@suse.com>, Keir Fraser <keir@xen.org>, Tamas K Lengyel <tklengyel@sec.in.tum.de>
List-Id: xen-devel@lists.xenproject.org

On Thu, 2015-03-12 at 13:25 +0000, Julien Grall wrote:
> On 12/03/15 13:18, Tamas K Lengyel wrote:
> >     > +    struct radix_tree_root mem_access_settings;
> >     >  };
> >     >
> >     >  /* List of possible type for each page in the p2m entry.
> >     > @@ -217,6 +230,26 @@ static inline int get_page_and_type(struct page_info *page,
> >     >  /* get host p2m table */
> >     >  #define p2m_get_hostp2m(d) (&(d)->arch.p2m)
> >     >
> >     > +/* mem_event and mem_access are supported on any ARM guest */
> >     > +static inline bool_t p2m_mem_access_sanity_check(struct domain *d)
> >     > +{
> >     > +    return 1;
> >     > +}
> >     > +
> >     > +static inline bool_t p2m_mem_event_sanity_check(struct domain *d)
> >     > +{
> >     > +    return 1;
> >     > +}
> >     > +
> >     > +/* Get access type for a pfn
> >     > + * If pfn == -1ul, gets the default access type */
> > 
> >     Ditto
> > 
> > 
> > Ack, however, all other comments here followed this style even for
> > multi-line comments. If I change the style only on my comments it will
> > be mixed (and ugly) IMHO.
> 
> Hmmm... right. Ian, Stefano, any comments?

Follow the existing style in the file.

> 
> Regards,
>