From: Joe Perches <joe@perches.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Andy Whitcroft <apw@canonical.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: remove unneeded or ("|")
Date: Thu, 12 Mar 2015 07:13:35 -0700 [thread overview]
Message-ID: <1426169615.32696.103.camel@perches.com> (raw)
In-Reply-To: <1426169269-15332-1-git-send-email-borntraeger@de.ibm.com>
On Thu, 2015-03-12 at 15:07 +0100, Christian Borntraeger wrote:
> while porting commit 89a883530fe7 ("checkpatch: ## is not a valid
> modifier") to QEMU, Peter Maydell noticed that the | at the end of
> the list is not necessary.
>
> Lets get rid of it in kernel checkpatch.pl
Andy? Was that meant to allow nothing?
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -1550,7 +1550,7 @@ sub possible {
> asm|__asm__|
> do|
> \#|
> - \#\#|
> + \#\#
> )(?:\s|$)|
> ^(?:typedef|struct|enum)\b
> )}x;
next prev parent reply other threads:[~2015-03-12 14:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 14:07 [PATCH] checkpatch: remove unneeded or ("|") Christian Borntraeger
2015-03-12 14:13 ` Joe Perches [this message]
2015-03-12 14:56 ` Andy Whitcroft
2015-03-24 11:54 ` Christian Borntraeger
2015-03-24 14:11 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426169615.32696.103.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=borntraeger@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.