From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH] xen: avoid updating node affinity twice
 when removing a CPU from a cpupool
Date: Thu, 12 Mar 2015 15:52:38 +0000
Message-ID: <1426175556.7023.41.camel@citrix.com>
References: <20150309164901.11859.95044.stgit@Solace.station>
	<550058BB.7000102@eu.citrix.com> <1426089874.21405.10.camel@citrix.com>
	<1426167922.7023.21.camel@citrix.com>
	<5501B5F80200007800069268@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1162104675552756319=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5501B5F80200007800069268@mail.emea.novell.com>
Content-Language: en-US
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "JBeulich@suse.com" <JBeulich@suse.com>
Cc: "JGross@suse.com" <JGross@suse.com>, "keir.xen@gmail.com" <keir.xen@gmail.com>, "jtweaver@hawaii.edu" <jtweaver@hawaii.edu>, George Dunlap <George.Dunlap@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

--===============1162104675552756319==
Content-Language: en-US
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-6bKC5mkC1+nFkFCqJduH"

--=-6bKC5mkC1+nFkFCqJduH
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2015-03-12 at 14:51 +0000, Jan Beulich wrote:
> >>> On 12.03.15 at 14:45, <dario.faggioli@citrix.com> wrote:
> > Patch below, and attached. However, I think the correct thing to do
> > would be to just revert 93be8285 "update domU's node-affinity on the
> > cpupool_unassign_cpu() path", wouldn't it?
>=20
> Indeed - if the presented patch is what we want, it should be
> carried out as a revert. But you'll then want to explain why you
> did what you did there in the first place:=20
>
Because I thought it was necessary. ISTR I spotted the lack of symmetry
that George is also mentioning, by looking at its _assign_ counterpart,
and did not notice, at that time, that it was actually ok, as the update
happens already, although in schedule.c...

> It surely wasn't without
> reason,=20
>
It was for a wrong reason. :-)

> and hence I'd be afraid the revert would re-introduce
> another problem. That explanation should then probably go in
> as description for the revert.
>=20
I'm not sure I'm getting 100% of what you mean. Let me try:

<<Change 93be8285 ("update domU's node-affinity on the
cpupool_unassign_cpu() path") is wrong. In fact, as a consequence of it,
domains' node affinity is updated twice when a pCPU is removed from a
cpupool. It seemed necessary to add such call in cpupool_unassign_cpu(),
for symmetry with its _assign_ counterpart, but it went unnoticed that
the update was already being performed, in cpu_disable_scheduler().

Besides being conceptually wrong, it causes issues, in the form of an
ASSERT() that triggers, in debug builds.

For these reasons, 93be8285 really needs to be undone.>>

Was it something like this you were after? If not, please advise
further... And sorry for the whole thing! :-/

Regards,
Dario

--=-6bKC5mkC1+nFkFCqJduH
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlUBtkQACgkQk4XaBE3IOsTcbACeLaxg7R+tObRpEAN0ZljLpY0p
oCEAoKTqGPn1erXhRwpeZqeDryD3Dhqx
=9smY
-----END PGP SIGNATURE-----

--=-6bKC5mkC1+nFkFCqJduH--


--===============1162104675552756319==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============1162104675552756319==--