From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH] xen: avoid updating node affinity twice when removing a CPU from a cpupool Date: Thu, 12 Mar 2015 15:56:38 +0000 Message-ID: <1426175796.7023.45.camel@citrix.com> References: <20150309164901.11859.95044.stgit@Solace.station> <550058BB.7000102@eu.citrix.com> <1426089874.21405.10.camel@citrix.com> <1426167922.7023.21.camel@citrix.com> <5501A83E.6090303@eu.citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6259360345620498494==" Return-path: In-Reply-To: <5501A83E.6090303@eu.citrix.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org Cc: "JGross@suse.com" , "jtweaver@hawaii.edu" , George Dunlap , "xen-devel@lists.xen.org" , "keir.xen@gmail.com" , "JBeulich@suse.com" List-Id: xen-devel@lists.xenproject.org --===============6259360345620498494== Content-Language: en-US Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-0plXPAZxr82rrB9gcVsP" --=-0plXPAZxr82rrB9gcVsP Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2015-03-12 at 14:52 +0000, George Dunlap wrote: > On 03/12/2015 01:45 PM, Dario Faggioli wrote: > > Patch below, and attached. However, I think the correct thing to do > > would be to just revert 93be8285 "update domU's node-affinity on the > > cpupool_unassign_cpu() path", wouldn't it? >=20 > Funny you should mention that...=20 > Being the author of this mess... I'm more sorry than amused, but yes I can imagine it's funny to see. :-) > one of the things I was thinking of > suggesting was trying to move the domain_update_node_affinity() out of > cpupool.c and into schedule.c, somewhere on the path that brings up a > cpu or assigns it to a pool, specifically so that the lack of symmetry > didn't trip anybody up. =20 > That would be good, indeed. > Now that I find out it already *has* tripped someone up, I think we had > definitely better do something about it. :-) > :-) > Let me take a look and see what seems sensible... >=20 Ok, let me know what you discover. If you're too busy and you want me to have a look, just say it (I'll do my best to get it right this time! ;-P) Regards, Dario --=-0plXPAZxr82rrB9gcVsP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlUBtzQACgkQk4XaBE3IOsT9wQCeIvr/M4kv0MfDmo/hxaakRyK0 gGoAn3MAcnftWt+B4RaltZulRQ7rjKbg =EycG -----END PGP SIGNATURE----- --=-0plXPAZxr82rrB9gcVsP-- --===============6259360345620498494== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============6259360345620498494==--