All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trond Myklebust <trond.myklebust@primarydata.com>
To: Anna Schumaker <Anna.Schumaker@netapp.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH v3] NFS: Don't zap caches on fallocate()
Date: Thu, 12 Mar 2015 11:57:39 -0400	[thread overview]
Message-ID: <1426175859.15787.1.camel@primarydata.com> (raw)
In-Reply-To: <1425571566-3117-1-git-send-email-Anna.Schumaker@Netapp.com>

Hi Anna,

On Thu, 2015-03-05 at 11:06 -0500, Anna Schumaker wrote:
> This patch adds a GETATTR to the end of ALLOCATE and DEALLOCATE
> operations so we can set the updated inode size and change attribute
> directly.  DEALLOCATE will still need to release pagecache pages, so
> nfs42_proc_deallocate() now calls truncate_pagecache_range() before
> contacting the server.
> 
> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
> ---
>  fs/nfs/inode.c          |  1 -
>  fs/nfs/nfs42proc.c      | 23 +++++++++++++++++++----
>  fs/nfs/nfs42xdr.c       | 20 ++++++++++++++++----
>  fs/nfs/nfs4file.c       |  1 -
>  include/linux/nfs_xdr.h |  4 ++++
>  5 files changed, 39 insertions(+), 10 deletions(-)
> 
> diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c
> index d42dff6..e92386f 100644
> --- a/fs/nfs/inode.c
> +++ b/fs/nfs/inode.c
> @@ -192,7 +192,6 @@ void nfs_zap_caches(struct inode *inode)
>         nfs_zap_caches_locked(inode);
>         spin_unlock(&inode->i_lock);
>  }
> -EXPORT_SYMBOL_GPL(nfs_zap_caches);

This patch appears to be completely whitespace-borked. Can you please
fix up your mailer and resend?

Thanks
  Trond
-- 
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@primarydata.com





  reply	other threads:[~2015-03-12 15:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-05 16:06 [PATCH v3] NFS: Don't zap caches on fallocate() Anna Schumaker
2015-03-12 15:57 ` Trond Myklebust [this message]
2015-03-16 17:42   ` Anna Schumaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426175859.15787.1.camel@primarydata.com \
    --to=trond.myklebust@primarydata.com \
    --cc=Anna.Schumaker@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.