Re: [PATCH v1 2/3] sched_credit2.c : runqueue_per_core code

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1130 bytes --]

On Thu, 2015-03-12 at 16:21 +0000, Jan Beulich wrote:
> >>> On 12.03.15 at 15:57, <uma.sharma523@gmail.com> wrote:

> > @@ -1940,10 +1946,14 @@ static void init_pcpu(const struct scheduler *ops, int cpu)
> >  
> >      /* Figure out which runqueue to put it in */
> >      /* NB: cpu 0 doesn't get a STARTING callback, so we hard-code it to runqueue 0. */
> > -    if ( cpu == 0 )
> > -        rqi = 0;
> > +    if ( opt_credit2_runqueue == CREDIT2_OPT_RUNQUEUE_SOCKET )
> > +    {
> > +        rqi = (cpu) ? cpu_to_socket(cpu) : boot_cpu_to_socket();
> > +    }
> >      else
> > -        rqi = cpu_to_socket(cpu);
> > +    {
> > +        rqi = (cpu) ? cpu_to_core(cpu) : boot_cpu_to_core();
> > +    }
> 
> Rather than extending the bad assumption of CPU 0 being the boot
> CPU (What if it gets offlined and this or another one onlined back
> as CPU 0?), can't you find a way to avoid depending on the numeric
> value of "cpu"?
> 
This is on me, i.e., I'm working on this and, when done, I'll include
Uma's patches in my series, adapting this bit (she agreed already to
this plan).

Regards,
Dario

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel