From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754172AbbCMA1M (ORCPT ); Thu, 12 Mar 2015 20:27:12 -0400 Received: from smtprelay0069.hostedemail.com ([216.40.44.69]:38105 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751588AbbCMA1K (ORCPT ); Thu, 12 Mar 2015 20:27:10 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:967:973:982:988:989:1260:1261:1263:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1714:1730:1747:1777:1792:2393:2525:2560:2563:2612:2682:2685:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:2975:3000:3022:3138:3139:3140:3141:3142:3350:3622:3770:3867:3870:3871:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:7652:8985:9025:9388:10004:10400:10848:11256:11257:11657:11658:11854:11914:12043:12296:12438:12517:12519:12555:12682:12740:13019:13069:13161:13229:13255:13311:13357:13848:14106:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: hall16_3e5fea4871638 X-Filterd-Recvd-Size: 1952 Message-ID: <1426206426.9314.4.camel@perches.com> Subject: Re: [PATCH v3 1/6] staging: rtl8192e: fix coding style issues (merge broken strings) From: Joe Perches To: Mateusz Kulikowski Cc: gregkh@linuxfoundation.org, mdcasey@chabloom.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Thu, 12 Mar 2015 17:27:06 -0700 In-Reply-To: <1426204401-20414-2-git-send-email-mateusz.kulikowski@gmail.com> References: <1426204401-20414-1-git-send-email-mateusz.kulikowski@gmail.com> <1426204401-20414-2-git-send-email-mateusz.kulikowski@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-03-13 at 00:53 +0100, Mateusz Kulikowski wrote: [] > diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c b/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c > index 0e6bdd2..01d2201 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c > +++ b/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c > @@ -47,8 +47,8 @@ void PHY_SetRF8256Bandwidth(struct net_device *dev, > 0x0e, bMask12Bits, 0x021); > > } else { > - RT_TRACE(COMP_ERR, "PHY_SetRF8256Bandwidth(): " > - "unknown hardware version\n"); > + RT_TRACE(COMP_ERR, > + "PHY_SetRF8256Bandwidth(): unknown hardware version\n"); Another thing you might consider is to change these embedded function names in another patch to use "%s: ", __func__ RT_TRACE(COMP_ERR, "%s: "unknown hardware version\n", __func__) There's a cocci script for that. http://cocci.systeme.lip6.narkive.com/nKXf6Bmy/finding-embedded-function-names