All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
To: "daniel@ffwll.ch" <daniel@ffwll.ch>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t 02/10] tests/kms_psr_sink_crc: Make render visible to human eyes
Date: Mon, 16 Mar 2015 20:23:19 +0000	[thread overview]
Message-ID: <1426537364.1670.40.camel@intel.com> (raw)
In-Reply-To: <20150316085939.GG21993@phenom.ffwll.local>

On Mon, 2015-03-16 at 09:59 +0100, Daniel Vetter wrote:
> On Fri, Mar 13, 2015 at 06:19:19PM -0400, Rodrigo Vivi wrote:
> > This will allow manual tests when crc isn't available.
> > 
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > ---
> >  tests/kms_psr_sink_crc.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c
> > index 0a56705..5085fb3 100644
> > --- a/tests/kms_psr_sink_crc.c
> > +++ b/tests/kms_psr_sink_crc.c
> > @@ -139,7 +139,7 @@ static void scratch_buf_init(struct igt_buf *buf, drm_intel_bo *bo)
> >  	buf->bo = bo;
> >  	buf->stride = 4096;
> >  	buf->tiling = I915_TILING_X;
> > -	buf->size = 4096;
> > +	buf->size = 4;
> 
> 4 looks a bit small ...

agree, but as far as I can remember with 4 I can have visible changes
and with 4096 I couldn't see any thing on screen even with psr
disabled. 

> -Daniel
> 
> >  }
> >  
> >  static void fill_render(data_t *data, uint32_t handle, unsigned char color)
> > @@ -167,7 +167,7 @@ static void fill_render(data_t *data, uint32_t handle, unsigned char color)
> >  	igt_assert(batch);
> >  
> >  	rendercopy(batch, NULL,
> > -		   &src_buf, 0, 0, 1, 1,
> > +		   &src_buf, 0, 0, 0xff, 0xff,
> >  		   &dst_buf, 0, 0);
> >  
> >  	intel_batchbuffer_free(batch);
> > -- 
> > 1.9.3
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-03-16 20:23 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-13 22:19 [PATCH i-g-t 01/10] tests/kms_psr_sink_crc: Make blt visible to human eyes Rodrigo Vivi
2015-03-13 22:19 ` [PATCH i-g-t 02/10] tests/kms_psr_sink_crc: Make render " Rodrigo Vivi
2015-03-16  8:59   ` Daniel Vetter
2015-03-16 20:23     ` Vivi, Rodrigo [this message]
2015-03-17 10:27       ` Daniel Vetter
2015-03-20  1:24         ` [PATCH] " Rodrigo Vivi
2015-03-20  9:54           ` Daniel Vetter
2015-03-20 17:43             ` Vivi, Rodrigo
2015-03-23  8:35               ` Daniel Vetter
2015-03-23  8:36                 ` Daniel Vetter
2015-03-23 21:53                   ` Vivi, Rodrigo
2015-03-24  9:02                     ` Daniel Vetter
2015-04-15  1:08                       ` Rodrigo Vivi
2015-03-13 22:19 ` [PATCH i-g-t 03/10] tests/kms_psr_sink_crc: Make mmaps " Rodrigo Vivi
2015-03-13 22:19 ` [PATCH i-g-t 04/10] tests/kms_psr_sink_crc: Make plane_move " Rodrigo Vivi
2015-03-13 22:19 ` [PATCH i-g-t 05/10] tests/kms_psr_sink_crc: Add manual mode Rodrigo Vivi
2015-03-13 22:19 ` [PATCH i-g-t 06/10] lib/igt_aux: Introduce igt_debug_warn_and_wait_for_key Rodrigo Vivi
2015-03-13 22:19 ` [PATCH i-g-t 07/10] tests/kms_psr_sink_crc: Use pressed key to pass/fail Rodrigo Vivi
2015-03-16  9:04   ` Daniel Vetter
2015-03-16  9:07     ` Daniel Vetter
2015-03-16 22:44     ` [PATCH] lib/igt_aux: Introduce igt_interactive_debug_manual_check Rodrigo Vivi
2015-03-17 10:28       ` Daniel Vetter
2015-03-20  1:11         ` Rodrigo Vivi
2015-03-20  9:55           ` Daniel Vetter
2015-03-13 22:19 ` [PATCH i-g-t 08/10] tests/kms_psr_sink_crc: remove timeout option from wait_psr_entry Rodrigo Vivi
2015-03-13 22:19 ` [PATCH i-g-t 09/10] test/kms_psr_sink_crc: Split plane setup operations Rodrigo Vivi
2015-03-13 22:19 ` [PATCH i-g-t 10/10] test/kms_psr_sink_crc: Add dpms off/on tests Rodrigo Vivi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426537364.1670.40.camel@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.