From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2 2/4] xen: sched: make counters for vCPU sleep and wakeup generic Date: Tue, 17 Mar 2015 10:48:57 +0000 Message-ID: <1426589336.32500.46.camel@citrix.com> References: <20150227163925.32500.15985.stgit@Solace.station> <20150227165110.32500.78336.stgit@Solace.station> <5507105E.2030208@eu.citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2594684142503955318==" Return-path: In-Reply-To: <5507105E.2030208@eu.citrix.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap Cc: "Keir (Xen.org)" , "mengxu@cis.upenn.edu" , "JBeulich@suse.com" , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org --===============2594684142503955318== Content-Language: en-US Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-PG0j32FYoDlmkckoVQD7" --=-PG0j32FYoDlmkckoVQD7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2015-03-16 at 17:18 +0000, George Dunlap wrote: > On 02/27/2015 04:51 PM, Dario Faggioli wrote: > > diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c > > index ad0a5d4..2b852cc 100644 > > --- a/xen/common/sched_credit2.c > > +++ b/xen/common/sched_credit2.c > > @@ -931,6 +931,7 @@ csched2_vcpu_sleep(const struct scheduler *ops, str= uct vcpu *vc) > > struct csched2_vcpu * const svc =3D CSCHED2_VCPU(vc); > > =20 > > BUG_ON( is_idle_vcpu(vc) ); > > + SCHED_STAT_CRANK(vcpu_sleep); > > =20 > > if ( per_cpu(schedule_data, vc->processor).curr =3D=3D vc ) > > cpu_raise_softirq(vc->processor, SCHEDULE_SOFTIRQ); > > @@ -956,19 +957,22 @@ csched2_vcpu_wake(const struct scheduler *ops, st= ruct vcpu *vc) > > =20 > > BUG_ON( is_idle_vcpu(vc) ); > > =20 > > - /* Make sure svc priority mod happens before runq check */ > > if ( unlikely(per_cpu(schedule_data, vc->processor).curr =3D=3D vc= ) ) > > { > > + SCHED_STAT_CRANK(vcpu_wake_running); > > goto out; > > } > > - > > if ( unlikely(__vcpu_on_runq(svc)) ) >=20 > Does this make the 'if' butt right up against the '{'? Is that bad? >=20 > Other than that: >=20 > Acked-by: George Dunlap >=20 As far as I can see, the series is in: http://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dcommit;h=3D8b0e94da0e23221a6= d7ea19bfbd24a407db44de8 and whoever committed it (Jan, probably?), took care of leaving that blank line in place, which I'm fine with, of course. :-) > However, it doesn't apply cleanly at the moment, so you'll probably need > to send a refresh. (Sorry for taking so long!) >=20 NP, and thanks for reviewing. I was prepared to refresh and resend, but as I said, it's been checked-in already, so thanks for that! :-D Regards, Dario --=-PG0j32FYoDlmkckoVQD7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlUIBpgACgkQk4XaBE3IOsRtOwCfbFs0Re/PfZCTumL+txM5P9fY JM0AoJIQ2g2EBn6XEJK0EEVWKty8p/Ws =kJVB -----END PGP SIGNATURE----- --=-PG0j32FYoDlmkckoVQD7-- --===============2594684142503955318== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============2594684142503955318==--