From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 4/5] libxl: vcpuset: Remove useless limit on max_vcpus. Date: Wed, 18 Mar 2015 13:13:48 +0000 Message-ID: <1426684428.14291.19.camel@citrix.com> References: <1426278403-12959-1-git-send-email-konrad.wilk@oracle.com> <1426278403-12959-5-git-send-email-konrad.wilk@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YYE0O-0007x5-HD for xen-devel@lists.xenproject.org; Wed, 18 Mar 2015 13:27:28 +0000 In-Reply-To: <1426278403-12959-5-git-send-email-konrad.wilk@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: xen-devel@lists.xenproject.org, ian.jackson@eu.citrix.com, wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On Fri, 2015-03-13 at 16:26 -0400, Konrad Rzeszutek Wilk wrote: > The check is superflous. If the 'max_vcpus' (argument > value) is greater than pCPU and --ignore-host has not > been supplied we would print an warning and return > and not call this code. > > If the --ignore-host parameter had been used we would > never end up in this condition and enforce 'max_vcpus'. > > The only time it would be invoked is if max_vcpus < host_cpu > in which case it would set max_vcpus to max_vcpus. > > In short - it is dead code. > > Signed-off-by: Konrad Rzeszutek Wilk Acked-by: Ian Campbell