From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 03/14] libxc: xc_core_arch_memory_map_get populate errno Date: Wed, 18 Mar 2015 16:18:59 +0000 Message-ID: <1426695539.14291.65.camel@citrix.com> References: <1426520383-20855-1-git-send-email-konrad.wilk@oracle.com> <1426520383-20855-4-git-send-email-konrad.wilk@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YYGu4-0000qn-9B for xen-devel@lists.xenproject.org; Wed, 18 Mar 2015 16:33:08 +0000 In-Reply-To: <1426520383-20855-4-git-send-email-konrad.wilk@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: xen-devel@lists.xenproject.org, ian.jackson@eu.citrix.com, wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On Mon, 2015-03-16 at 11:39 -0400, Konrad Rzeszutek Wilk wrote: > with proper value (ENOMEM) when reporting failures. > > Signed-off-by: Konrad Rzeszutek Wilk > --- > [v1: errno before using PERROR] > --- > tools/libxc/xc_core_arm.c | 1 + > tools/libxc/xc_core_x86.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/tools/libxc/xc_core_arm.c b/tools/libxc/xc_core_arm.c > index 16508e7..34185cf 100644 > --- a/tools/libxc/xc_core_arm.c > +++ b/tools/libxc/xc_core_arm.c > @@ -54,6 +54,7 @@ xc_core_arch_memory_map_get(xc_interface *xch, struct xc_core_arch_context *unus > map = malloc(sizeof(*map)); > if ( map == NULL ) > { > + errno = ENOMEM; http://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html#tag_16_311 says that malloc will set errno itself: "Otherwise, it shall return a null pointer [CX] [Option Start] and set errno to indicate the error"