From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44276) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYTAa-0000HL-Ko for qemu-devel@nongnu.org; Thu, 19 Mar 2015 01:39:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYTAW-0006N6-Fu for qemu-devel@nongnu.org; Thu, 19 Mar 2015 01:39:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38769) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYTAW-0006Mw-BL for qemu-devel@nongnu.org; Thu, 19 Mar 2015 01:38:56 -0400 Date: Thu, 19 Mar 2015 13:28:26 +0800 From: Jason Wang Message-Id: <1426742906.5002.7@smtp.corp.redhat.com> In-Reply-To: <20150318140555-mutt-send-email-mst@redhat.com> References: <1426671309-13645-1-git-send-email-jasowang@redhat.com> <1426671309-13645-9-git-send-email-jasowang@redhat.com> <20150318140555-mutt-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Subject: Re: [Qemu-devel] [PATCH V4 08/19] virtio-net: fix the upper bound when trying to delete queues List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: cornelia.huck@de.ibm.com, qemu-devel@nongnu.org On Wed, Mar 18, 2015 at 9:06 PM, Michael S. Tsirkin wrote: > On Wed, Mar 18, 2015 at 05:34:58PM +0800, Jason Wang wrote: >> Virtqueue were indexed from zero, so don't delete virtqueue whose >> index is n->max_queues * 2 + 1. >> >> Cc: Michael S. Tsirkin >> Signed-off-by: Jason Wang > > Bugfix? needed on master? stable? Only for host that supports more than 8 tuntap queues. But seems a candidate for both master and stable. I will post this with patch 7 as an independent patches just for 2.3. > >> --- >> hw/net/virtio-net.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c >> index 59f76bc..b6fac9c 100644 >> --- a/hw/net/virtio-net.c >> +++ b/hw/net/virtio-net.c >> @@ -1309,7 +1309,7 @@ static void >> virtio_net_set_multiqueue(VirtIONet *n, int multiqueue) >> >> n->multiqueue = multiqueue; >> >> - for (i = 2; i <= n->max_queues * 2 + 1; i++) { >> + for (i = 2; i < n->max_queues * 2 + 1; i++) { >> virtio_del_queue(vdev, i); >> } >> >> -- >> 2.1.0 >