From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2 3/7] x86: detect and initialize Intel CAT feature Date: Thu, 19 Mar 2015 12:44:49 +0000 Message-ID: <1426769087.2560.123.camel@citrix.com> References: <1426761695-12545-1-git-send-email-chao.p.peng@linux.intel.com> <1426761695-12545-4-git-send-email-chao.p.peng@linux.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6124607545685605288==" Return-path: In-Reply-To: <1426761695-12545-4-git-send-email-chao.p.peng@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "chao.p.peng@linux.intel.com" Cc: Wei Liu , Ian Campbell , Andrew Cooper , "xen-devel@lists.xen.org" , "will.auld@intel.com" , Stefano Stabellini , "JBeulich@suse.com" , Ian Jackson , "dgdegra@tycho.nsa.gov" , "Keir (Xen.org)" List-Id: xen-devel@lists.xenproject.org --===============6124607545685605288== Content-Language: en-US Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-zxHwuEPW1ci0xA+oy8lw" --=-zxHwuEPW1ci0xA+oy8lw Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2015-03-19 at 18:41 +0800, Chao Peng wrote: > diff --git a/docs/misc/xen-command-line.markdown b/docs/misc/xen-command-= line.markdown > index 63871cb..768c55f 100644 > --- a/docs/misc/xen-command-line.markdown > +++ b/docs/misc/xen-command-line.markdown > @@ -1090,9 +1090,9 @@ This option can be specified more than once (up to = 8 times at present). > > `=3D ` > =20 > ### psr (Intel) > -> `=3D List of ( cmt: | rmid_max: )` > +> `=3D List of ( cmt: | rmid_max: | cat: | nu= m_sockets: )` > As Tim, I also don't like the 'num_sockets' part of the interface. Actually, I'm not sure I understand what the idea behind this parameter is. You say: =20 > +* Cache Alllocation Technology (Broadwell and later). Information regar= ding > + the cache allocation. > + * `cat` instructs Xen to enable/disable Cache Allocation Technology. > + * `num_sockets` indicates the number of available sockets for CAT feat= ure > + detection. All the sockets up to num_sockets will be checked for CAT > + feature.=20 > What it the use case of specifying, say, num_sockets=3D2, on a 4 socket system?=20 Is it for making it possible for the user to disable the feature on some of the socket? If yes, I think it does make sense, but then why always the last ones? shouldn't this be a list of socket IDs? Something like: sockets=3D0,2 meaning that the user wants the feature enabled _exactly_ on socket 0 and 2 (if available there, of course). Regards, Dario --=-zxHwuEPW1ci0xA+oy8lw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlUKxL8ACgkQk4XaBE3IOsSErwCeIaLlJfxQW42Jev/w3PSZHgiP aowAn052NuOsA40nr0md+cpmgL+bQGL5 =C0uf -----END PGP SIGNATURE----- --=-zxHwuEPW1ci0xA+oy8lw-- --===============6124607545685605288== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============6124607545685605288==--