From: Ian Campbell <ian.campbell@citrix.com>
To: Quan Xu <quan.xu@intel.com>
Cc: kevin@koconnor.net, xen-devel@lists.xen.org,
qemu-devel@nongnu.org, stefano.stabellini@eu.citrix.com,
stefanb@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom vTPM for HVM virtual machine
Date: Thu, 19 Mar 2015 12:56:50 +0000 [thread overview]
Message-ID: <1426769810.610.64.camel@citrix.com> (raw)
In-Reply-To: <1425989764-2926-2-git-send-email-quan.xu@intel.com>
On Tue, 2015-03-10 at 08:16 -0400, Quan Xu wrote:
> @@ -151,6 +152,8 @@ device_hardware_setup(void)
> esp_scsi_setup();
> megasas_setup();
> pvscsi_setup();
> + if (runningOnXen())
> + vtpm4hvm_setup();
Is there anything which is actually Xen specific about the driver in
tpm.[ch]? Would it be better to just probe for it, perhaps gates by a
Kconfig option which enables TPM support.
And following that train of thought I think you could reasonable drop
"4hvm" from the name. And possibly even the leading "v", since I suppose
seabios shouldn't really care if the tpm is emulated or real so long as
it looks like a real tpm.
Ian.
next prev parent reply other threads:[~2015-03-19 12:57 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 12:16 [Qemu-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom vTPM for HVM virtual machine Quan Xu
2015-03-10 12:16 ` Quan Xu
2015-03-10 12:16 ` [Qemu-devel] " Quan Xu
2015-03-19 12:56 ` Ian Campbell
2015-03-19 12:56 ` Ian Campbell [this message]
2015-03-20 1:35 ` Xu, Quan
2015-03-20 1:35 ` [Qemu-devel] [Xen-devel] " Xu, Quan
2015-03-20 12:00 ` Stefan Berger
2015-03-20 12:00 ` [Qemu-devel] [Xen-devel] " Stefan Berger
2015-03-20 11:43 ` Stefan Berger
2015-03-20 11:43 ` [Qemu-devel] [Xen-devel] " Stefan Berger
2015-03-23 1:47 ` Xu, Quan
2015-03-23 10:57 ` Stefan Berger
2015-03-23 12:03 ` Xu, Quan
2015-03-23 20:00 ` Stefan Berger
2015-03-24 2:20 ` [Qemu-devel] " Xu, Quan
2015-03-24 2:20 ` [Qemu-devel] [Xen-devel] " Xu, Quan
2015-03-24 15:21 ` Stefan Berger
2015-03-25 1:51 ` [Qemu-devel] " Xu, Quan
2015-03-25 1:51 ` [Qemu-devel] [Xen-devel] " Xu, Quan
2015-03-24 15:21 ` [Qemu-devel] " Stefan Berger
2015-03-23 20:00 ` Stefan Berger
2015-03-23 12:03 ` Xu, Quan
2015-03-23 10:57 ` Stefan Berger
2015-03-23 1:47 ` Xu, Quan
2015-03-10 12:16 ` Quan Xu
2015-03-11 19:49 ` Kevin O'Connor
2015-03-11 19:49 ` [Qemu-devel] " Kevin O'Connor
2015-03-12 2:54 ` Xu, Quan
2015-03-12 2:54 ` Xu, Quan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426769810.610.64.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=kevin@koconnor.net \
--cc=qemu-devel@nongnu.org \
--cc=quan.xu@intel.com \
--cc=stefanb@linux.vnet.ibm.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.