From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v3 3/7] vTPM: add TPM TCPA and SSDT for HVM
 virtual machine when vTPM is added
Date: Thu, 19 Mar 2015 13:02:14 +0000
Message-ID: <1426770134.610.68.camel@citrix.com>
References: <1425989642-2758-1-git-send-email-quan.xu@intel.com>
	<1425989642-2758-4-git-send-email-quan.xu@intel.com>
	<20150313154633.GF19822@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150313154633.GF19822@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: keir@xen.org, Quan Xu <quan.xu@intel.com>, stefano.stabellini@eu.citrix.com, tim@xen.org, stefanb@linux.vnet.ibm.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, jbeulich@suse.com, samuel.thibault@ens-lyon.org, dgdegra@tycho.nsa.gov
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-03-13 at 15:46 +0000, Wei Liu wrote:
> On Tue, Mar 10, 2015 at 08:13:58AM -0400, Quan Xu wrote:
> > Signed-off-by: Quan Xu <quan.xu@intel.com>
> > ---
> >  tools/firmware/hvmloader/acpi/build.c | 7 ++++---
> >  tools/libxl/libxl_create.c            | 5 ++++-
> >  2 files changed, 8 insertions(+), 4 deletions(-)
> > 
> > diff --git a/tools/firmware/hvmloader/acpi/build.c b/tools/firmware/hvmloader/acpi/build.c
> > index 1431296..49f6772 100644
> > --- a/tools/firmware/hvmloader/acpi/build.c
> > +++ b/tools/firmware/hvmloader/acpi/build.c
> > @@ -313,9 +313,10 @@ static int construct_secondary_tables(unsigned long *table_ptrs,
> >  
> >      /* TPM TCPA and SSDT. */
> >      tis_hdr = (uint16_t *)0xFED40F00;
> > -    if ( (tis_hdr[0] == tis_signature[0]) &&
> > -         (tis_hdr[1] == tis_signature[1]) &&
> > -         (tis_hdr[2] == tis_signature[2]) )
> > +    if (((tis_hdr[0] == tis_signature[0]) &&
> > +        (tis_hdr[1] == tis_signature[1]) &&
> 
> These two lines are not necessary. They are not functional change and
> violate coding style.

Yes, this series so far has been full of this sort of thing. which is
rather obscuring what is going on.

I think I'll wait for a v4 with these issues fixed before I look at the
rest of it.

Ian.