From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v4 10/11] osstest: add a script to install
 Xen on FreeBSD hosts
Date: Thu, 19 Mar 2015 15:24:10 +0000
Message-ID: <1426778650.21742.37.camel@citrix.com>
References: <1424276291-6872-1-git-send-email-roger.pau@citrix.com>
	<1424276291-6872-11-git-send-email-roger.pau@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1YYcMb-0006Tk-3G
	for xen-devel@lists.xenproject.org; Thu, 19 Mar 2015 15:28:01 +0000
In-Reply-To: <1424276291-6872-11-git-send-email-roger.pau@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org, Ian Jackson <Ian.Jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-02-18 at 17:18 +0100, Roger Pau Monne wrote:

> +sub setupboot () {
> +    my $xenhopt = "dom0pvh=1";
> +
> +    my $cons= get_host_property($ho, 'XenSerialConsole', 'com1');
> +
> +    if ( $cons eq "com1" ) {
> +	$xenhopt .= " com1=$c{Baud},8n1 console=com1,vga gdb=com1";
> +    } elsif ( $cons eq "dtuart" ) {
> +	$xenhopt .= " console=dtuart";
> +	my $dtuart= get_host_property($ho, 'XenDTUARTPath', undef);
> +	$xenhopt .= " dtuart=$dtuart" if $dtuart;
> +    } else {
> +	logm("No Xen console device defined for host");
> +    }
> +    if (toolstack()->{Dom0MemFixed}) {
> +        $xenhopt .= " dom0_mem=2048M,max:2048M";
> +    }
> +    my $append= $r{xen_boot_append};
> +    $xenhopt .= " $append" if defined $append;
> +    $append = get_host_property($ho, 'xen-commandline-append', undef);
> +    $xenhopt .= " $append" if defined $append;

Perhaps some or all of this could be common with ts-xen-install?

> +    die "pci-passthrough is not supported" if host_involves_pcipassthrough($ho);

If a host is passthrough capable does that imply that the current job is
going to use it? It seems the two hosts with a passthrough-* host flag
are gall-mite and itch-mite which are certainly used for other jobs.

I'm not sure how this can be dealt with, maybe Ian has an idea, or maybe
you can just defer until a FreeBSD w/ passthrough job is created, at
which point you would surely know what to write here.