Re: [PATCH v4 11/11] osstest: add FreeBSD build recipe

[Ian Campbell <ian.campbell@citrix.com>]

On Wed, 2015-02-18 at 17:18 +0100, Roger Pau Monne wrote:
> This patch introduces two new buildjobs:
> 
> build-<arch>-freebsd-xen: sets up a FreeBSD host and builds Xen.
> build-<arch>-freebsd-freebsd: sets up a FreeBSD host and builds FreeBSD sets
> and a mfsBSD installer image.

Not sure why this is dodgy, it doesn't look too bad to me.

One thought I had all the way through this is that its a bit wrong that
ts-xen-{install,build} and ts-kernel-build are actually
ts-xen-{install,build}-linux and ts-linux-build.

Renaming those script would allow some of the iffs you are added to be
replace with do-a-thing-$os.

A little care would be needed so that the testid doesn't change, but
that's might be a good thing, since having the testid be host-install
regardless of the OS being installed would make things a bit more
readable IMHO (e.g. in the summary grid).

Perhaps the way to achieve that is to make ts-xen-build be:
    #!/bin/bash
    set -ex
    os=$1;shift
    exec ts-xen-build-$1 $@

Then things like:
    per-host-ts broken  host-install/@(*) ts-host-install + $os
    per-host-ts .       xen-install/@     ts-xen-install + $os

(the + makes the $os not be in the test id)

Ian.