From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 13/13] libxc: Fix do_memory_op to return negative value on errors Date: Thu, 19 Mar 2015 16:51:18 +0000 Message-ID: <1426783878.21742.78.camel@citrix.com> References: <1426724659-23999-1-git-send-email-konrad.wilk@oracle.com> <1426724659-23999-14-git-send-email-konrad.wilk@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YYdqW-0007wz-Q0 for xen-devel@lists.xenproject.org; Thu, 19 Mar 2015 17:03:00 +0000 In-Reply-To: <1426724659-23999-14-git-send-email-konrad.wilk@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: xen-devel@lists.xenproject.org, ian.jackson@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On Wed, 2015-03-18 at 20:24 -0400, Konrad Rzeszutek Wilk wrote: > instead of the -Exx values (which should go in errno). > > This patch has HUGE implications. There is a lot of APIs > that are using do_memory_op. Fortunately most of them > check for 'if (do_memory_op(..) < 0)' so will function > properly. However there were some which printed the return > value to the user. They have been fixed in: > > libxc: Don't assign return value to errno for E820 get/set xc_ calls. > libxc: Check xc_sharing_* for proper return values. > libxc: If xc_domain_add_to_physmap fails, include errno value > libxc: Check xc_maximum_ram_page for negative return values. > libxc: Check xc_domain_maximum_gpfn for negative return values > > Signed-off-by: Konrad Rzeszutek Wilk Acked-by: Ian Campbell