From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 4/5] libxl: use new QEMU xenstore protocol Date: Thu, 19 Mar 2015 17:06:33 +0000 Message-ID: <1426784793.21742.85.camel@citrix.com> References: <1426771086-9026-1-git-send-email-wei.liu2@citrix.com> <1426771086-9026-5-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1426771086-9026-5-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: stefano.stabellini@eu.citrix.com, ian.jackson@eu.ctrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Thu, 2015-03-19 at 13:18 +0000, Wei Liu wrote: > entries = libxl__xs_directory(gc, 0, GCSPRINTF( > - "/local/domain/0/device-model/%d/physmap", domid), &num); > + "/local/domain/%d/device-model/%d/physmap", > + dm_domid, domid), &num); You've missed an opportunity to use your new helper, I think. With that fixed: Acked-by: Ian Campbell