From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47924)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1YYpjG-0000qA-KG
	for qemu-devel@nongnu.org; Fri, 20 Mar 2015 01:44:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1YYpjB-0001T4-GY
	for qemu-devel@nongnu.org; Fri, 20 Mar 2015 01:44:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39656)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1YYpjB-0001Su-BU
	for qemu-devel@nongnu.org; Fri, 20 Mar 2015 01:44:13 -0400
Date: Fri, 20 Mar 2015 13:43:09 +0800
From: Jason Wang <jasowang@redhat.com>
Message-Id: <1426830189.5879.3@smtp.corp.redhat.com>
In-Reply-To: <20150319110319-mutt-send-email-mst@redhat.com>
References: <1426671309-13645-1-git-send-email-jasowang@redhat.com>
	<1426671309-13645-19-git-send-email-jasowang@redhat.com>
	<20150318134611-mutt-send-email-mst@redhat.com>
	<1426742363.5002.2@smtp.corp.redhat.com>
	<20150319110319-mutt-send-email-mst@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Subject: Re: [Qemu-devel] [PATCH V4 18/19] pci: remove hard-coded bar size
 in msix_init_exclusive_bar()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: cornelia.huck@de.ibm.com, Keith Busch <keith.busch@intel.com>, Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>



On Thu, Mar 19, 2015 at 6:09 PM, Michael S. Tsirkin <mst@redhat.com> 
wrote:
> On Thu, Mar 19, 2015 at 01:19:23PM +0800, Jason Wang wrote:
>>  
>>  
>>  On Wed, Mar 18, 2015 at 8:52 PM, Michael S. Tsirkin 
>> <mst@redhat.com> wrote:
>>  >On Wed, Mar 18, 2015 at 05:35:08PM +0800, Jason Wang wrote:
>>  >> This patch let msix_init_exclusive_bar() can accept bar_size 
>> parameter
>>  >> other than a hard-coded limit 4096. Then caller can specify a 
>> bar_size
>>  >> depends on msix entries and can use up to 2048 msix entries as 
>> PCI
>>  >> spec allows. To keep migration compatibility, 4096 is used for 
>> all
>>  >> callers and pba were start from half of bar size.
>>  >> Cc: Keith Busch <keith.busch@intel.com>
>>  >> Cc: Kevin Wolf <kwolf@redhat.com>
>>  >> Cc: Stefan Hajnoczi <stefanha@redhat.com>
>>  >> Cc: Michael S. Tsirkin <mst@redhat.com>
>>  >> Signed-off-by: Jason Wang <jasowang@redhat.com>
>>  >
>>  >Hmm this API looks strange. Caller will then have to have
>>  >msi specific knowledge.
>>  >Can't we keep the size iternal to msix.c?
>>  
>>  Looks like we can, but still need an extra parameter e.g a boolean
>>  compat_size to let msix_init_exclusive_bar() to use 4096 as bar 
>> size.
> 
> Why not just figure the size out from # of vectors?

Yes, for 2.4 we can figure the size out from the number of vectors.