From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v3] libxl/libxl_qmp.c: fix error handling in
	qmp_open
Date: Fri, 20 Mar 2015 11:56:44 +0000
Message-ID: <1426852604.21742.153.camel@citrix.com>
References: <1426747230-30579-1-git-send-email-pramod.devendra@citrix.com>
	<1426769712-1524-1-git-send-email-pramod.devendra@citrix.com>
	<20150320100843.GL16267@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1YYvXl-0006SD-2v
	for xen-devel@lists.xenproject.org; Fri, 20 Mar 2015 11:56:49 +0000
In-Reply-To: <20150320100843.GL16267@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel@lists.xenproject.org, PRAMOD DEVENDRA <pramod.devendra@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-03-20 at 10:08 +0000, Wei Liu wrote:
> On Thu, Mar 19, 2015 at 12:55:12PM +0000, PRAMOD DEVENDRA wrote:
> > From: Pramod Devendra <pramod.devendra@citrix.com>
> > 
> > 1. Make sure sun_path does not overflow
> > 2. Close qmp_fd on error
> > 3. Use goto out for error handling
> > 
> > Signed-off-by: Pramod Devendra <pramod.devendra@citrix.com>
> > CC: Ian Jackson <ian.jackson@eu.citrix.com>
> > CC: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > CC: Ian Campbell <ian.campbell@citrix.com>
> > CC: Wei Liu <wei.liu2@citrix.com>
> 
> Acked-by: Wei Liu <wei.liu2@citrix.com>

Applied, thanks.

Pramod, my queue folder contains several patches from you with a
confusing variety of versions ("2/2", "1/3", "v2"), however I think they
are all precursors of this one and so I have moved them to my done
folder. If there was another patch in there then please resend.