From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v5 3/8] sysctl: Make XEN_SYSCTL_topologyinfo
 sysctl a little more efficient
Date: Fri, 20 Mar 2015 13:25:00 +0000
Message-ID: <1426857900.21742.178.camel@citrix.com>
References: <1426802044-19444-1-git-send-email-boris.ostrovsky@oracle.com>
	<1426802044-19444-4-git-send-email-boris.ostrovsky@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1426802044-19444-4-git-send-email-boris.ostrovsky@oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: elena.ufimtseva@oracle.com, wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, jbeulich@suse.com, keir@xen.org
List-Id: xen-devel@lists.xenproject.org

On Thu, 2015-03-19 at 17:53 -0400, Boris Ostrovsky wrote:
[...]
> * Replace INVALID_TOPOLOGY_ID with "XEN_"-prefixed macros for each invalid type
>   (core, socket, node).

But not for distance:

> @@ -1375,7 +1360,7 @@ static PyObject *pyxc_numainfo(XcObject *self)
>          for ( j = 0; j <= max_node_index; j++ )
>          {
>              uint32_t dist = nodes_dist[i*(max_node_index+1) + j];
> -            if ( dist == INVALID_TOPOLOGY_ID )
> +            if ( dist == ~0u )

?

Other than that the tools side here looks ok.