From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v5 6/8] libxl/libxc: Move
 libxl_get_cpu_topology()'s hypercall buffer management to libxc
Date: Fri, 20 Mar 2015 13:54:37 +0000
Message-ID: <1426859677.21742.192.camel@citrix.com>
References: <1426802044-19444-1-git-send-email-boris.ostrovsky@oracle.com>
	<1426802044-19444-7-git-send-email-boris.ostrovsky@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1426802044-19444-7-git-send-email-boris.ostrovsky@oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: elena.ufimtseva@oracle.com, wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, jbeulich@suse.com, keir@xen.org
List-Id: xen-devel@lists.xenproject.org

On Thu, 2015-03-19 at 17:54 -0400, Boris Ostrovsky wrote:
> +    if (cputopo) {
> +        if ((ret = xc_hypercall_bounce_pre(xch, cputopo)))

I think this guy will tolerate a NULL here (and on post), so I
think/hope you can get away without this conditional stuff. Can you give
it a go please.

The rest looked ok.