From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v5 7/8] libxl/libxc: Move libxl_get_numainfo()'s hypercall buffer management to libxc Date: Fri, 20 Mar 2015 14:21:48 +0000 Message-ID: <1426861308.21742.198.camel@citrix.com> References: <1426802044-19444-1-git-send-email-boris.ostrovsky@oracle.com> <1426802044-19444-8-git-send-email-boris.ostrovsky@oracle.com> <20150320134901.GE29188@l.oracle.com> <550C2A59.4080904@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <550C2A59.4080904@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Boris Ostrovsky Cc: elena.ufimtseva@oracle.com, keir@xen.org, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, jbeulich@suse.com, wei.liu2@citrix.com List-Id: xen-devel@lists.xenproject.org On Fri, 2015-03-20 at 10:10 -0400, Boris Ostrovsky wrote: > I actually think it's the other way around: when I made the first change > in 4/8 I added spaces, which this file's style generally doesn't use. > > Which, conveniently, is different from the style used by xc_misc.c Right, libxc uses the Xen coding style (top-level CODING_STYLE) while libxl uses its own (tools/libxc/CODING_STYLE). In some cases for very loose values of "uses" though, sorry. > And I am quite confused about curly bracket positions. They are all over > the place (pun intended). In libxc they go on the next line (Xen style) in libxl they go on the same line (libxl style). Ian.