From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 3/3] libxl: Domain destroy: fork Date: Fri, 20 Mar 2015 16:03:49 +0000 Message-ID: <1426867429.21742.216.camel@citrix.com> References: <1426606259-9692-1-git-send-email-jfehlig@suse.com> <1426606259-9692-4-git-send-email-jfehlig@suse.com> <1426681640.18247.359.camel@citrix.com> <550C3953.7000604@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <550C3953.7000604@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jim Fehlig Cc: Ian.Jackson@eu.citrix.com, wei.liu2@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Fri, 2015-03-20 at 09:14 -0600, Jim Fehlig wrote: > Ian Campbell wrote: > > On Tue, 2015-03-17 at 09:30 -0600, Jim Fehlig wrote: > > > >> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c > >> index b6541d4..b43db1a 100644 > >> --- a/tools/libxl/libxl.c > >> +++ b/tools/libxl/libxl.c > >> @@ -1481,6 +1481,10 @@ static void domain_destroy_callback(libxl__egc *egc, > >> static void destroy_finish_check(libxl__egc *egc, > >> libxl__domain_destroy_state *dds); > >> > >> +static void domain_destroy_domid_cb(libxl__egc *egc, > >> + libxl__ev_child *destroyer, > >> + pid_t pid, int status); > >> > > > > This seems misplaced, doesn't it want to go before libxl__destroy_domid > > just after the prototype of devices_destroy_cb, which is where it lives > > in the sequence? > > > > Yes, I think you are right. Here an adjusted patch. Acked + applied, thanks!