From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751960AbbCUMLi (ORCPT <rfc822;w@1wt.eu>);
	Sat, 21 Mar 2015 08:11:38 -0400
Received: from cpsmtpb-ews07.kpnxchange.com ([213.75.39.10]:53230 "EHLO
	cpsmtpb-ews07.kpnxchange.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751832AbbCUMLh (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 21 Mar 2015 08:11:37 -0400
Message-ID: <1426939895.15426.12.camel@x220>
Subject: Re: [PATCH 1/1] Add mkopci driver
From: Paul Bolle <pebolle@tiscali.nl>
To: Richard Weinberger <richard.weinberger@gmail.com>
Cc: sergej.bauer@gmail.com, LKML <linux-kernel@vger.kernel.org>,
        Arnd Bergmann <arnd@arndb.de>, Greg KH <gregkh@linuxfoundation.org>
Date: Sat, 21 Mar 2015 13:11:35 +0100
In-Reply-To: <CAFLxGvyqbzjE0yU=KmH+fci2eokqPVixfiU7mpFQApcM7LrU8w@mail.gmail.com>
References: <201503201510.26639.sergej.bauer@gmail.com>
	 <CAFLxGvyqbzjE0yU=KmH+fci2eokqPVixfiU7mpFQApcM7LrU8w@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-OriginalArrivalTime: 21 Mar 2015 12:11:35.0751 (UTC) FILETIME=[2D43CD70:01D063D0]
X-RcptDomain: vger.kernel.org
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2015-03-20 at 13:43 +0100, Richard Weinberger wrote:
> Sergej,
> 
> On Fri, Mar 20, 2015 at 1:10 PM,  <sergej.bauer@gmail.com> wrote:
> > mkopci (MB11.xx) device (RC Module project) provides data transference through a serial bus bar according to MIL-STD-1553.
> > the driver used for operating devices, reads PCI configuration space and pass interrupts to user-space applications.
> >
> > Please consider adding this patch to the linux-next queue.
> 
> From a quick look I'd suggest to get the driver first in shape.
> 
> - You add new proc files, which is not really welcomed. Please consider sysfs.
> - In the debug prints you compare against current->comm, also not nice.
> - You use printk() in the interrupt handler.
> - Why is this a misc driver at all? Does it really not fit into any
> other device class?
> - I'm sure running checkpatch.pl against the patch would also not hurt. :)
 
And an additional, trivial, change you might also consider is using
    MODULE_LICENSE("GPL v2");

as that would match the license stated in the comment at the top of
drivers/misc/mkopci.c.


Paul Bolle