From: Joe Perches <joe@perches.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org, Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH -next] netfilter: Use LOGLEVEL_<FOO> defines
Date: Mon, 23 Mar 2015 08:43:09 -0700 [thread overview]
Message-ID: <1427125389.16851.23.camel@perches.com> (raw)
In-Reply-To: <20150323135235.GA7595@salvia>
On Mon, 2015-03-23 at 14:52 +0100, Pablo Neira Ayuso wrote:
> I would also prefer if you include the explicit header files in that
> patch too. Could you send us a v2? Please, Cc:
> netfilter-devel@vger.kernel.org
As I wrote to Stephen, I'd prefer to #include
kernel.h where it's not already specified.
net/netfilter/nft_log.c does, every other
modified file doesn't.
Is that OK with you?
next prev parent reply other threads:[~2015-03-23 15:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-23 3:08 linux-next: manual merge of the net-next tree with the net tree Stephen Rothwell
2015-03-23 3:08 ` Stephen Rothwell
2015-03-23 12:47 ` Pablo Neira Ayuso
2015-03-23 12:55 ` Joe Perches
2015-03-23 13:06 ` Pablo Neira Ayuso
2015-03-23 13:23 ` [PATCH -next] netfilter: Use LOGLEVEL_<FOO> defines Joe Perches
2015-03-23 13:38 ` Stephen Rothwell
2015-03-23 13:52 ` Pablo Neira Ayuso
2015-03-23 15:43 ` Joe Perches [this message]
2015-03-23 18:50 ` [PATCH V2 " Joe Perches
2015-03-25 11:19 ` Pablo Neira Ayuso
2015-03-23 15:36 ` [PATCH " Joe Perches
2015-03-24 2:29 ` linux-next: manual merge of the net-next tree with the net tree David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427125389.16851.23.camel@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.