From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [OSSTEST Nested PATCH 2/6] Add and expose some testsupport APIs Date: Tue, 24 Mar 2015 09:45:19 +0000 Message-ID: <1427190319.21742.314.camel@citrix.com> References: <86C3224E41A7434B904EC364302132D80E478552@SHSMSX101.ccr.corp.intel.com> <1426854029.21742.169.camel@citrix.com> <9E79D1C9A97CFD4097BCE431828FDD31B6E9AD@SHSMSX103.ccr.corp.intel.com> <1427104190.10125.8.camel@citrix.com> <9E79D1C9A97CFD4097BCE431828FDD31B6F924@SHSMSX103.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <9E79D1C9A97CFD4097BCE431828FDD31B6F924@SHSMSX103.ccr.corp.intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "Hu, Robert" Cc: "wei.liu2@citrix.com" , "Pang, LongtaoX" , "Ian.Jackson@eu.citrix.com" , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Tue, 2015-03-24 at 03:34 +0000, Hu, Robert wrote: > > Make it an option to the function which creates the configuration in the > > first place. Quoting myself from earlier in this very thread: > Then we still need to designate to use e1000 device somewhere; say, in > ts-nested-setup, we store this designation in runvar. > Then when creating the config, according to your proposal, we plumbing > such designation through $xopts, since we see it in runvar. Are you OK > with such implementation? I'm not sure if this should be a runvar or just something which ts-nested-setup knows. That's one for Ian J to decide. > But if like above, I would prefer to altering/manipulating guest configation > directly in ts-nested-setup after normal guest is setup. Since this is more > simple and constrained to nested case only. IMHO, this should be properly integrated into the configuration creation, not fixed up later as an adhoc step. Ian.