From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 10/29] libxl: events: Make timeout and async exec setup take an ao, not a gc Date: Tue, 24 Mar 2015 11:09:46 +0000 Message-ID: <1427195386.21742.344.camel@citrix.com> References: <1423599016-32639-1-git-send-email-ian.jackson@eu.citrix.com> <1423599016-32639-11-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1423599016-32639-11-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xensource.com, Euan Harris , Lai Jiangshan , Wen Congyang , Yang Hongyang List-Id: xen-devel@lists.xenproject.org On Tue, 2015-02-10 at 20:09 +0000, Ian Jackson wrote: > Change the timeout setup functions to take a libxl__ao, not a > libxl__gc. This is going to be needed for ao cancellation, because > timeouts are going to be a main hook for ao cancellation - so the > timeouts need to be associated with an ao. > > This means that timeouts can only occur as part of a long-running > libxl function (but this is of course correct, as libxl shouldn't have > any global timeouts, and indeed all the call sites have an ao). > > Also remove the gc parameter from libxl__async_exec_start. It can > just use the gc from the ao supplied in the aes. > > All the callers follow the obvious patterns and therefore supply the > ao's gc to libxl__async_exec_start and the timeout setup functions. > There is therefore no functional change in this patch. > > Signed-off-by: Ian Jackson > CC: Yang Hongyang > CC: Wen Congyang > CC: Lai Jiangshan Acked-by: Ian Campbell