Re: [PATCH OSSTEST] start/stop the guest 10 times in the standard test jobs

[Ian Campbell <ian.campbell@citrix.com>]

On Tue, 2015-03-24 at 12:42 +0000, Ian Campbell wrote:
> On Tue, 2015-03-24 at 12:37 +0000, Ian Jackson wrote:
> > Ian Campbell writes ("[PATCH OSSTEST] start/stop the guest 10 times in the standard test jobs"):
> > > We already arrange by more adhoc means to repeat a localhost migration
> > > 10 times.
> > 
> > Assuming you have tested this and observed that it generates the right
> > testid,
> 
> Now you mention it, I have not, I should and will though.

$ OSSTEST_SIMULATE=1 ./standalone run-job -h cam-st10 test-amd64-amd64-xl
$ grep testid logs/standalone/test-amd64-amd64-xl.log
[...]
2015-03-24 12:50:13 Z standalone.test-amd64-amd64-xl ========== 18 testid guest-stop/host/debian/;/host.repeat ==========
[...]

So clearly not right! Adding:

diff --git a/sg-run-job b/sg-run-job
index be7b648..f2c70cf 100755
--- a/sg-run-job
+++ b/sg-run-job
@@ -316,7 +316,7 @@ proc test-guest-nomigr {g} {
     run-ts . =   ts-guest-stop    + host $g
     run-ts . =.2 ts-guest-start   + host $g
 
-    repeat-ts 10 =.repeat + \
+    repeat-ts 10 =.repeat \
                + ts-guest-stop    host   $g \; \
                + ts-guest-start + host + $g +
 

results in "18 testid guest-start/debian.repeat" which I think is more
like it. See below.

Ian.

8<----------------------

>From aae447a6b7b1c4e8d583375da4ed19451d844e75 Mon Sep 17 00:00:00 2001
From: Ian Campbell <ian.campbell@citrix.com>
Date: Wed, 11 Mar 2015 10:08:57 +0000
Subject: [PATCH] start/stop the guest 10 times in the standard test jobs

The recent libvirt failures seemed to happen after a couple of
stop/start pairs, so arrange to start/stop each guest 10 times.

By cribbing from the existing use of repeat-ts I hope I've arranged
for a new test with testid ts-guest-start/debian.repeat.

We already arrange by more adhoc means to repeat a localhost migration
10 times.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
v2: Correct placement of + to generate testid
guest-start/debian.repeat and not some rubbish.
---
 sg-run-job | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/sg-run-job b/sg-run-job
index a1ff24b..f2c70cf 100755
--- a/sg-run-job
+++ b/sg-run-job
@@ -315,6 +315,11 @@ proc test-guest {g} {
 proc test-guest-nomigr {g} {
     run-ts . =   ts-guest-stop    + host $g
     run-ts . =.2 ts-guest-start   + host $g
+
+    repeat-ts 10 =.repeat \
+               + ts-guest-stop    host   $g \; \
+               + ts-guest-start + host + $g +
+
     run-ts . =   ts-guest-destroy + host $g
 }
 
-- 
2.1.4