From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v3 1/5] libxl: introduce libxl__device_model_xs_path Date: Tue, 24 Mar 2015 14:32:42 +0000 Message-ID: <1427207562.21742.406.camel@citrix.com> References: <1426868353-31557-1-git-send-email-wei.liu2@citrix.com> <1426868353-31557-2-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1426868353-31557-2-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Fri, 2015-03-20 at 16:19 +0000, Wei Liu wrote: > +_hidden char *libxl__device_model_xs_path(libxl__gc *gc, uint32_t dm_domid, > + uint32_t domid, > + const char *format, ...); This should have the PRINTF_ATTRIBUTE thing and not the double space before "...". With that fixed: Acked-by: Ian Campbell Since this is pretty minor if you want to resend just this one patch, or even send an incremental fixup to be folded in I can take care of it on commit. Ian.