From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v3] xentop: add support for qdisks
Date: Tue, 24 Mar 2015 15:01:39 +0000
Message-ID: <1427209299.21742.424.camel@citrix.com>
References: <55107DAC02000091000F31CF@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <55107DAC02000091000F31CF@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Charles Arnold <carnold@suse.com>
Cc: xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Mon, 2015-03-23 at 20:55 -0600, Charles Arnold wrote:

> +/* Get up to 1024 active domains */

What I meant last time was, is this limitation a concern? What if there
are 1025 domains?

If this is a concern then perhaps refactor such that the qdisk stats
gathering collection can happen from the inner loop of xenstat_get_node,
i.e. near the call to domain_get_tmem_stats, then you would be given the
single domain of interest. Might simplify some other stuff too.

Ian.