From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 1/2] introduce gprintk()
Date: Tue, 24 Mar 2015 15:42:23 +0000
Message-ID: <1427211743.21742.445.camel@citrix.com>
References: <550C44F1020000780006C1A5@mail.emea.novell.com>
	<550C46F0020000780006C1C1@mail.emea.novell.com>
	<1427206853.21742.402.camel@citrix.com> <55117ED0.30509@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1YaR1S-0007m8-TS
	for xen-devel@lists.xenproject.org; Tue, 24 Mar 2015 15:45:43 +0000
In-Reply-To: <55117ED0.30509@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>
Cc: Keir Fraser <keir@xen.org>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>, Julien Grall <julien.grall@citrix.com>, Jan Beulich <JBeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, xen-devel <xen-devel@lists.xenproject.org>
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-03-24 at 15:12 +0000, Julien Grall wrote:
> Hi Ian,
> 
> On 24/03/2015 14:20, Ian Campbell wrote:
> > @@ -1709,7 +1707,6 @@ static void do_cp15_64(struct cpu_user_regs *regs,
> >           break;
> >       default:
> >           {
> > -#ifndef NDEBUG
> >               struct hsr_cp64 cp64 = hsr.cp64;
> >
> >               gdprintk(XENLOG_ERR,
> > @@ -1718,7 +1715,6 @@ static void do_cp15_64(struct cpu_user_regs *regs,
> >                        cp64.op1, cp64.reg1, cp64.reg2, cp64.crm, regs->pc);
> >               gdprintk(XENLOG_ERR, "unhandled 64-bit CP15 access %#x\n",
> >                        hsr.bits & HSR_CP64_REGS_MASK);
> > -#endif
> 
> Did you try to build with debug=n ? I suspect that GCC will warn about 
> the unused cp64.

I did, and it didn't.

Ian.