All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dario Faggioli <dario.faggioli@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Jackson <Ian.Jackson@citrix.com>,
	Stefano Stabellini <Stefano.Stabellini@citrix.com>,
	Ian Campbell <Ian.Campbell@citrix.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH 1/3] libxl: check whether vcpu affinity and vnuma info match
Date: Tue, 24 Mar 2015 15:47:27 +0000	[thread overview]
Message-ID: <1427212045.2560.221.camel@citrix.com> (raw)
In-Reply-To: <20150324144149.GD30219@zion.uk.xensource.com>


[-- Attachment #1.1: Type: text/plain, Size: 1708 bytes --]

On Tue, 2015-03-24 at 14:41 +0000, Wei Liu wrote:
> On Tue, Mar 24, 2015 at 02:41:48PM +0100, Dario Faggioli wrote:

> Currently all the checks that returns error are all guest visible
> mis-configurations. I'm trying to reason whether we should return an
> error or just print a warning.
> 
> What is the outcome if you have conflicting setting in vNUMA and vcpu
> affinity? 
>
The outcome is that vcpus will either always run (if hard affinity and
vnuma info mismatch) or prefer to run (if soft affinity and vnuma info
mismatch) on pcpus from pnode(s) different from the pnode specified in
vnuma configuration, and hence where the memory is.

So, for instance, with this:

 vnuma = [ [ "pnode=0","size=1000","vcpus=0-1","vdistances=10,20"  ],
           [ "pnode=1","size=1000","vcpus=2-3","vdistances=20,10"  ] ]

and this:

 cpus_soft = "node:1"
 cpus = "node:0"

in the config file, we have a soft affinity mismatch for vcpus 0,1 and
an hard affinity mismatch for vcpus 2,3.

This means that vcpus 0,1 can run everywhere, but they will prefer to
run on pcpus from pnode 1, while, when the domain was built, they've
been assigned to vnode 0, which has its memory allocated from pnode 0.
This will (potentially) cause a lot of remote memory accesses.

It also means that vcpus 2,3 will only run on pcpus from node:0, while
they've been assigned to vnode 1, which has its memory allocated from
pnode 1. This will mean all memory accesses will be remote memory
accesses

So no functional consequences, but performance will most likely be
affected.

> I guess it's just performance penalty but nothing guest
> visible could happen?
> 
Exactly.

Regards,
Dario

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2015-03-24 15:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-24 13:41 [PATCH 0/3] Automatically derive soft affinity from vnuma information Dario Faggioli
2015-03-24 13:41 ` [PATCH 1/3] libxl: check whether vcpu affinity and vnuma info match Dario Faggioli
2015-03-24 14:41   ` Wei Liu
2015-03-24 15:47     ` Dario Faggioli [this message]
2015-03-24 15:56       ` Wei Liu
2015-03-24 13:42 ` [PATCH 2/3] libxl: automatically set soft affinity after vnuma info Dario Faggioli
2015-03-24 14:32   ` Wei Liu
2015-03-24 15:06     ` Dario Faggioli
2015-03-24 15:23       ` Wei Liu
2015-03-24 13:42 ` [PATCH 3/3] libxl: cleanup some misuse of 'cpumap' as parameter Dario Faggioli
2015-03-24 14:33   ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427212045.2560.221.camel@citrix.com \
    --to=dario.faggioli@citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Ian.Jackson@citrix.com \
    --cc=Stefano.Stabellini@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.