From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 3/5] INSTALL: mention variables for
	reproducible builds
Date: Tue, 24 Mar 2015 15:55:29 +0000
Message-ID: <1427212529.21742.451.camel@citrix.com>
References: <1426872279-5001-1-git-send-email-olaf@aepfle.de>
	<1426872279-5001-4-git-send-email-olaf@aepfle.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1426872279-5001-4-git-send-email-olaf@aepfle.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Olaf Hering <olaf@aepfle.de>
Cc: Keir Fraser <keir@xen.org>, Tim Deegan <tim@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>, Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-03-20 at 18:24 +0100, Olaf Hering wrote:
> Mention two variables introduced by commit ac977f5 ("use more fixed
> strings to build the hypervisor").
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Keir Fraser <keir@xen.org>
> Cc: Tim Deegan <tim@xen.org>
> ---
>  INSTALL | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/INSTALL b/INSTALL
> index 33f65ba..eac34b4 100644
> --- a/INSTALL
> +++ b/INSTALL
> @@ -209,6 +209,12 @@ changed with these variables.
>  XEN_WHOAMI=
>  XEN_DOMAIN=
>  
> +Some components of xen and tools will include an unpredictable timestamp
> +into the binaries. To allow reproducible builds the following variables
> +can be used to provide fixed timestamps in the expected format.
> +XEN_BUILD_DATE=any

I'm not sure what this implies I'm allowed to pass here...

Perhaps both cases would benefit from adding "(e.g. something like hte
output from <...>)" where <...> is the date invocation which is used if
the variable isn't set?

> +XEN_BUILD_TIME=hh:mm:ss
> +
>  The following variables can be used to tweak some aspects of the
>  hypervisor build.
>  verbose=y