From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 5/5] hvmloader: add knob for fixed VGABIOS
	date string
Date: Tue, 24 Mar 2015 15:57:20 +0000
Message-ID: <1427212640.21742.453.camel@citrix.com>
References: <1426872279-5001-1-git-send-email-olaf@aepfle.de>
	<1426872279-5001-6-git-send-email-olaf@aepfle.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1426872279-5001-6-git-send-email-olaf@aepfle.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Olaf Hering <olaf@aepfle.de>
Cc: Wei Liu <wei.liu2@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-03-20 at 18:24 +0100, Olaf Hering wrote:
> To allow reproducible builds of hvmloader introduce a make variable
> VGABIOS_REL_DATE="dd Mon yyyy" to provide a fixed date string. Without
> this change the hvmloader binary changes with every rebuild.
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> ---
>  INSTALL                         | 1 +
>  tools/firmware/vgabios/Makefile | 4 ++--
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/INSTALL b/INSTALL
> index 198cb9d..1b67c36 100644
> --- a/INSTALL
> +++ b/INSTALL
> @@ -215,6 +215,7 @@ can be used to provide fixed timestamps in the expected format.
>  XEN_BUILD_DATE=any
>  XEN_BUILD_TIME=hh:mm:ss
>  SMBIOS_REL_DATE=mm/dd/yyyy
> +VGABIOS_REL_DATE="dd Mon yyyy"

This is getting to be a rather long list of overrides.

Is it expected that they should all be settable independently? Or would
one global setting be sufficient?

If so then a single variable which can be set to something accepted by
date -d which could be formatted in each location would seem preferable.

Ian.