From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: Ian vs Ian, round 0 Was:Re: [PATCH v3 7/7] libxl/vcpu-set - allow to decrease vcpu count on overcommitted guests (v3) Date: Tue, 24 Mar 2015 16:01:35 +0000 Message-ID: <1427212895.21742.455.camel@citrix.com> References: <1427134861-18881-1-git-send-email-konrad.wilk@oracle.com> <1427134861-18881-8-git-send-email-konrad.wilk@oracle.com> <1427211706.21742.444.camel@citrix.com> <20150324155604.GG14418@l.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YaRUq-00052v-Ne for xen-devel@lists.xenproject.org; Tue, 24 Mar 2015 16:16:04 +0000 In-Reply-To: <20150324155604.GG14418@l.oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: wei.liu2@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Tue, 2015-03-24 at 11:56 -0400, Konrad Rzeszutek Wilk wrote: > > More generally all of these rc == ERROR_DOMAIN_NOTFOUND check and prints > > are going to get rather tiresome, especially if/when there are other > > interesting error codes. Perhaps we could arrange for something further > > down the stack on libxl to log this sort of thing, such that xl can rely > > on it already having been mentioned? > > > > e.g. libxl_domain_info could do it perhaps? > > That would be the easiest way. Should I drop > > libxl: Add ERROR_DOMAIN_NOTFOUND for libxl_domain_info when it cannot find the domain > > and just add an LIBXL__LOG_ERRNO and keep on returning the old error value > (ERROR_INVAL)? No. I was suggesting that it should log *and* return DOMAIN_NOTFOUND, not that the return code wasn't a good thing. > Ian J recommended to add this new ERROR_DOMAIN_NOTFOUND in libxl_domain_info > so I think I will let you two fight it out! (changing the title to catch > Ian J's attention) I haven't contradicted this. Ian,