From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v3 1/5] libxl: introduce
 libxl__device_model_xs_path
Date: Tue, 24 Mar 2015 17:18:00 +0000
Message-ID: <1427217480.21742.465.camel@citrix.com>
References: <1426868353-31557-1-git-send-email-wei.liu2@citrix.com>
	<1426868353-31557-2-git-send-email-wei.liu2@citrix.com>
	<1427207562.21742.406.camel@citrix.com>
	<20150324144959.GE30219@zion.uk.xensource.com>
	<1427216003.21742.456.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1427216003.21742.456.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel@lists.xen.org, ian.jackson@eu.citrix.com, Jan Beulich <JBeulich@suse.com>, stefano.stabellini@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-03-24 at 16:53 +0000, Ian Campbell wrote:
> On Tue, 2015-03-24 at 14:49 +0000, Wei Liu wrote:
> > On Tue, Mar 24, 2015 at 02:32:42PM +0000, Ian Campbell wrote:
> > > On Fri, 2015-03-20 at 16:19 +0000, Wei Liu wrote:
> > > > +_hidden char *libxl__device_model_xs_path(libxl__gc *gc, uint32_t dm_domid,
> > > > +                                          uint32_t domid,
> > > > +                                          const char *format,  ...);
> > > 
> > > This should have the PRINTF_ATTRIBUTE thing and not the double space
> > > before "...".
> > > 
> > > With that fixed: Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > > 
> > > Since this is pretty minor if you want to resend just this one patch, or
> > > even send an incremental fixup to be folded in I can take care of it on
> > > commit.
> > > 
> > 
> > Here is an incremental fix.
> 
> Thanks, I folded that in and pushed the first 4 patches in this series.
> 
> The final patch (Revert "x86/hvm: wait for at least one ioreq server to
> be enabled") needs an x86 ack which it currently lacks so I've left this
> for now (Jan, I guess you'll pick it up or ask me to do so once you've
> acked it)

Jan: Note that patch 4/5 got reverted, so patch 5 (the revert quoted
above) shouldn't go in just yet.

Ian.