From: Joe Perches <joe@perches.com>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: rtl8723au: Update RT_TRACE macro and uses
Date: Tue, 24 Mar 2015 17:34:56 -0700 [thread overview]
Message-ID: <1427243696.12126.24.camel@perches.com> (raw)
In-Reply-To: <wrfjegodj4xj.fsf@redhat.com>
On Tue, 2015-03-24 at 20:28 -0400, Jes Sorensen wrote:
> Joe Perches <joe@perches.com> writes:
> > Create an rt_trace function using %pV to reduce overall code size.
> > Update the macro uses to remove unnecessary and now harmful parentheses.
[]
> This could be further improved by fixing up all the places where the
> function name is hard coded into the print statement, instead of using
> __func__. In particular as a lot of it is carried over from old code
> and has been renamed since.
There's a cocci script for that.
http://cocci.systeme.lip6.narkive.com/nKXf6Bmy/finding-embedded-function-names
I expect someone will run it one day on staging.
prev parent reply other threads:[~2015-03-25 0:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 18:10 [PATCH] staging: rtl8723au: Remove uses of MAC_FMT and MAC_ARG Joe Perches
2015-03-24 18:25 ` Jes Sorensen
2015-03-24 23:06 ` [PATCH] staging: rtl8723au: Update RT_TRACE macro and uses Joe Perches
2015-03-25 0:28 ` Jes Sorensen
2015-03-25 0:34 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427243696.12126.24.camel@perches.com \
--to=joe@perches.com \
--cc=Jes.Sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.