Re: [PATCH OSSTEST 2/2] uboot: make flask loading address host property

[Ian Campbell <ian.campbell@citrix.com>]

On Tue, 2015-03-24 at 11:45 +0000, Wei Liu wrote:
> Please set host property 'UBootSetFlaskAddrR' to 0x1200000.

Sigh, I wasn't having a very good day yesterday, since I completely
failed to do this.

I've now done:
OSSTEST_CONFIG=production-config ./mg-hosts setprops  marilith-n4 marilith-n5 -- UBootSetFlaskAddrR 0x1200000

and will make a note to figure out and set good addresses for the ARM
boards in the new colo.

Since flight 36721 hasn't run any x86 build jobs yet and it has already
failed the test-armhf-armhf*-xsm jobs I've killed it so it gets another
bite of the cherry.

Ian.

> ---
>  Osstest/Debian.pm | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm
> index b829878..9f7705e 100644
> --- a/Osstest/Debian.pm
> +++ b/Osstest/Debian.pm
> @@ -158,10 +158,16 @@ sub setupboot_uboot ($$$$) {
>  	    # Use the flaskpolicy from tools build job because we might
>  	    # want to test cross releases policy compatibility.
>  	    my $flaskpolicy = get_runvar('flaskpolicy',$r{buildjob});
> +	    my $flask_policy_addr_r =
> +		get_host_property($ho, 'UBootSetFlaskAddrR', undef);
> +	    my $set_flask_addr_r =
> +		$flask_policy_addr_r ?
> +		"setenv flask_policy_addr_r $flask_policy_addr_r" : "";
> +
>  	    $xenhopt .= " flask=enforcing";
>  	    $flask_commands = <<END;
>  
> -setenv flask_policy_addr_r 0x1200000
> +${set_flask_addr_r}
>  flaskpolicy=`readlink -f /boot/$flaskpolicy`
>  ext2load scsi 0 \\\${flask_policy_addr_r} \$flaskpolicy
>  fdt mknod /chosen module\@2