From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 5/5] hvmloader: add knob for fixed VGABIOS date string Date: Wed, 25 Mar 2015 10:55:21 +0000 Message-ID: <1427280921.10784.59.camel@citrix.com> References: <1426872279-5001-1-git-send-email-olaf@aepfle.de> <1426872279-5001-6-git-send-email-olaf@aepfle.de> <1427212640.21742.453.camel@citrix.com> <20150325084622.GA11487@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150325084622.GA11487@aepfle.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Olaf Hering Cc: Wei Liu , Stefano Stabellini , Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Wed, 2015-03-25 at 09:46 +0100, Olaf Hering wrote: > On Tue, Mar 24, Ian Campbell wrote: > > > Is it expected that they should all be settable independently? Or would > > one global setting be sufficient? > > A single timestamp would be nice, sure. > > > If so then a single variable which can be set to something accepted by > > date -d which could be formatted in each location would seem preferable. > > I did consider that. But that adds a dependency on 'date -d'. Not sure > if every build environment supports that. On Linux everyone will most > likely run date(1) from coreutils, which understands -d. Not sure about > BSD. I dont have access to BSD right now to check if their date > understands it. Their online manuals state that -d means something > else... > > http://netbsd.gw.com/cgi-bin/man-cgi?date++NetBSD-current > http://www.freebsd.org/cgi/man.cgi?query=date > http://www.openbsd.org/cgi-bin/man.cgi/OpenBSD-current/man1/date.1?query=date Plus http://pubs.opengroup.org/onlinepubs/9699919799/utilities/date.html doesn't mention -d at all, which si a shame. > In the end I think its acceptable to have a number of variables from > environment or make cmdline. Its only used during automated package > build. OK, I guess we can live with it. Ian.