All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Daniel Baluta <daniel.baluta@intel.com>
Cc: jic23@kernel.org, jlbec@evilplan.org, lars@metafoo.de,
	knaack.h@gmx.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org, octavian.purdila@intel.com
Subject: Re: [PATCH 1/3] iio: configfs: Add configfs support to IIO
Date: Wed, 25 Mar 2015 21:14:59 +0100	[thread overview]
Message-ID: <1427314499.10958.36.camel@x220> (raw)
In-Reply-To: <1427302832-9336-2-git-send-email-daniel.baluta@intel.com>

A license nit.

On Wed, 2015-03-25 at 19:00 +0200, Daniel Baluta wrote:
> --- /dev/null
> +++ b/drivers/iio/industrialio-configfs.c

> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License version 2 as published by
> + * the Free Software Foundation.

> +MODULE_AUTHOR("Daniel Baluta <daniel.baluta@intel.com>");
> +MODULE_DESCRIPTION("Industrial I/O configfs support");

You probably want
    MODULE_LICENSE("GPL v2");

here too. Because now, at module load time, the license will default to
"unspecified" which will taint the kernel.


Paul Bolle


  parent reply	other threads:[~2015-03-25 20:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-25 17:00 [PATCH 0/3] Add configfs support for software triggers in IIO Daniel Baluta
2015-03-25 17:00 ` [PATCH 1/3] iio: configfs: Add configfs support to IIO Daniel Baluta
2015-03-25 17:23   ` Peter Meerwald
2015-03-25 20:14   ` Paul Bolle [this message]
2015-03-26 10:13     ` Daniel Baluta
2015-03-27 17:17   ` Lars-Peter Clausen
2015-03-28 11:50     ` Jonathan Cameron
2015-03-31 13:20       ` Daniel Baluta
2015-03-25 17:00 ` [PATCH 2/3] iio: trigger: Add support for highres timer trigger Daniel Baluta
2015-03-25 17:00 ` [PATCH 3/3] iio: Documentation: Add initial documentaton for IIO Daniel Baluta
2015-03-25 17:22   ` Peter Meerwald
2015-03-25 19:28     ` Daniel Baluta
2015-03-28 11:53       ` Jonathan Cameron
2015-03-31 14:33         ` Daniel Baluta
2015-03-28 11:54   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427314499.10958.36.camel@x220 \
    --to=pebolle@tiscali.nl \
    --cc=daniel.baluta@intel.com \
    --cc=jic23@kernel.org \
    --cc=jlbec@evilplan.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=octavian.purdila@intel.com \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.